linux-kernel - Re: [PATCH Resend] dma: imx-dma: fix imxdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101102074038.GC6017@pengutronix.de>
Date:	Tue, 2 Nov 2010 08:40:38 +0100
From:	Pengutronix <s.hauer@...gutronix.de>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Thiago Farina <tfransosi@...il.com>
Subject: Re: [PATCH Resend] dma: imx-dma: fix imxdma_probe error path

On Tue, Nov 02, 2010 at 09:56:11AM +0800, Axel Lin wrote:
> Otherwise, the i variable will be -1 inside the latest iteration of the while loop.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Sascha Hauer <s.hauer@...gutronix.de>

> ---
> This resend only update the commit log.
> Regards,
> Axel
> 
>  drivers/dma/imx-dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index f629e49..e53d438 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -379,7 +379,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_init:
> -	while (i-- >= 0) {
> +	while (--i >= 0) {
>  		struct imxdma_channel *imxdmac = &imxdma->channel[i];
>  		imx_dma_free(imxdmac->imxdma_channel);
>  	}
> -- 
> 1.7.2
> 
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/