linux-kernel - Re: Resend [PATCH 3/4] MacbookAir3,1 and 3,2 hid support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Nov 2010 09:20:25 -0400 (EDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	gimli <gimli@...k-green.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Resend  [PATCH 3/4] MacbookAir3,1 and 3,2 hid support

On Tue, 26 Oct 2010, gimli wrote:

> This patch adds support for the new MacBookAir3,1 and 3,2 to the hid
> driver.
> 
> Updated names names acording Apples kext.
> 
> Signed-off-by: Edgar (gimli) Hucek <gimli@...k-green.com>

> -               trans = apple_find_translation((hid->product < 0x21d ||
> +               if(hid->product >= 0x023f && hid->product <= 0x0244 ) {
> +                       trans = apple_find_translation(macbookair_fn_keys, usage->code);
> +               } else {
> +                       trans = apple_find_translation((hid->product < 0x21d ||
>                                        hid->product >= 0x300) ?
>                                        powerbook_fn_keys : apple_fn_keys,
>                                        usage->code);

Could you please make this nicer? Having if and ternary operator both 
there to chose the translation table looks really confusing.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/