linux-kernel - Re: Resend [PATCH 3/4] MacbookAir3,1 and 3,2 hid support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1011030953540.15851@pobox.suse.cz>
Date:	Wed, 3 Nov 2010 09:56:21 -0400 (EDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	gimli <gimli@...k-green.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Resend  [PATCH 3/4] MacbookAir3,1 and 3,2 hid support

On Wed, 3 Nov 2010, gimli wrote:

> Does this look better ? 

What I would actually prefer would be something like


	if ( ... )
		table = macbookair_fn_keys;
	else if ( ... )
		table = powerbook_fn_keys;
	else
		table = apple_fn_keys;

	apple_find_translation(table, usage->code);

> I also use the USB id's for the if.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/