linux-kernel - Re: CFQ and dm-crypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CD185C2.8000006@dcs.fmph.uniba.sk>
Date:	Wed, 03 Nov 2010 16:54:42 +0100
From:	Richard Kralovic <Richard.Kralovic@....fmph.uniba.sk>
To:	Jeff Moyer <jmoyer@...hat.com>
CC:	linux-kernel@...r.kernel.org, axboe@...nel.dk
Subject: Re: CFQ and dm-crypt

On 11/03/10 04:23, Jeff Moyer wrote:
>> > CFQ io scheduler relies on using task_struct current to determine which
>> > process makes the io request. On the other hand, some dm modules (such
>> > as dm-crypt) use separate threads for doing io. As CFQ sees only these
>> > threads, it provides a very poor performance in such a case.
>> >
>> > IMHO the correct solution for this would be to store, for every io
>> > request, the process that initiated it (and preserve this information
>> > while the request is processed by device mapper). Would that be feasible?
> Sure.  Try the attached patch (still an rfc) and let us know how it
> goes.  In my environment, it speed up multiple concurrent buffered
> readers.  I wasn't able to do a full analysis via blktrace as 2.6.37-rc1
> seems to have broken blktrace support on my system.

Thanks for the patch. Unfortunately, I got a kernel panic quite soon
after booting the patched kernel. I was not able to reproduce the
panic in a virtual machine, so I had to manually note the backtrace,
thus I apologize that it's incomplete:

Fatal exception in interupt.
...
do_invalid_op
cic_free_func 0x9d/0xb0
bio_endio 0x42/0x70
task_rq_lock
try_to_wake_up
invalid_op
cic_free_func
cfq_free_io_context
put_io_context
cfq_put_request
...

When I combined the patch with my previous hack on dm-crypt, it worked
fine; so the problem apparently goes away if cfq sees the corret io
context.

Moreover, I noticed in the sources that cfq still uses current task on
many places. For example, the CPU scheduler settings are inherited if
there is no io priority set. Hence I was wondering if it does not make
more sense to store whole task_struct of the initiating process in
bio, instead of just io_context?

Greets
      Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/