linux-kernel - [PATCH] vmstat: fix offset calculation on void*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101103175648.GA6398@localhost>
Date:	Thu, 4 Nov 2010 01:56:49 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	"mrubin@...gle.com" <mrubin@...gle.com>,
	"david@...morbit.com" <david@...morbit.com>,
	"axboe@...nel.dk" <axboe@...nel.dk>,
	"kosaki.motohiro@...fujitsu.com" <kosaki.motohiro@...fujitsu.com>,
	"nickpiggin@...oo.com.au" <nickpiggin@...oo.com.au>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] vmstat: fix offset calculation on void*

Fix regression introduced by commit 79da826aee6.

	BUG: unable to handle kernel paging request at 07c06d16
	IP: [<c050c336>] strnlen+0x6/0x20

	Call Trace:
	 [<c050a249>] ? string+0x39/0xe0
	 [<c042be6b>] ? __wake_up_common+0x4b/0x80
	 [<c050afcc>] ? vsnprintf+0x1ec/0x380
	 [<c04b380e>] ? seq_printf+0x2e/0x60
	 [<c04829a6>] ? vmstat_show+0x26/0x30
	 [<c04b3bb6>] ? seq_read+0xa6/0x380
	 [<c04b3b10>] ? seq_read+0x0/0x380
	 [<c04d5d2f>] ? proc_reg_read+0x5f/0x90
	 [<c049c4a1>] ? vfs_read+0xa1/0x140
	 [<c04d5cd0>] ? proc_reg_read+0x0/0x90
	 [<c049c981>] ? sys_read+0x41/0x70
	 [<c0402bd0>] ? sysenter_do_call+0x12/0x26


CC: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
CC: Michael Rubin <mrubin@...gle.com>
Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
---

Hopefully Tetsuo can test it soon, thanks!

 mm/vmstat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.orig/mm/vmstat.c	2010-11-04 01:49:12.000000000 +0800
+++ linux-2.6/mm/vmstat.c	2010-11-04 01:49:23.000000000 +0800
@@ -949,7 +949,7 @@ static void *vmstat_start(struct seq_fil
 	v[PGPGIN] /= 2;		/* sectors -> kbytes */
 	v[PGPGOUT] /= 2;
 #endif
-	return m->private + *pos;
+	return (unsigned long *)m->private + *pos;
 }
 
 static void *vmstat_next(struct seq_file *m, void *arg, loff_t *pos)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/