linux-kernel - Re: [PATCHv1] staging: Synaptics RMI4 touchpad driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101103181058.GE7441@kroah.com>
Date:	Wed, 3 Nov 2010 11:10:58 -0700
From:	Greg KH <greg@...ah.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Naveen Kumar GADDIPATI <naveen.gaddipati@...ricsson.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	STEricsson_nomadik_linux <STEricsson_nomadik_linux@...t.st.com>,
	linux-input@...r.kernel.org
Subject: Re: [PATCHv1] staging: Synaptics RMI4 touchpad driver support

On Tue, Nov 02, 2010 at 08:40:30AM -0700, Dmitry Torokhov wrote:
> On Tue, Nov 02, 2010 at 03:14:48PM +0100, Linus Walleij wrote:
> > Greg KH wrote:
> > 
> > >> +Wait for the official upstream synaptics rmi4 clearpad drivers as promised over the past few months
> > >> +Merge any device support needed from this driver into it
> > >> +Delete this driver
> > > 
> > > Huh?
> > > 
> > > Why not just add this driver to the kernel tree instead?  When the
> > > "promised" driver then eventually shows up (who is promising it?) then
> > > delete the thing.
> 
> The same reason as there were several wireless drivers in staging?

Ok, that's a good enough reason for me :)

> > Well, Alan (on behalf of Ramesh Agarwal) sent out a very similar
> > patch (Titled "Synaptics TM1217 Touchscreen Controller driver")
> > the other day, and OTOMH that was after discussions with Synaptics
> > where they said they were working on a "real" driver (a rather
> > complex RMI4 bus driver) and we believe they will fix that sooner
> > or later.
> > 
> > So, until sooner or later happens we thought we'd keep it in staging.
> > 
> > If you prefer both Alan and we can probably submit our patches for
> > inclusion in the proper place.
> > 
> > A side effect may be that the Synaptics RMI4 people may have trouble
> > to merge their driver into input/ since they may be requested to
> > refactor the existing drivers to use it rather than merging new stuff,
> > putting some burden on their shoulders.
> > 
> 
> No, they have not been requested to change any existing [in tree]
> drivers. They however been asked to convert to the driver core
> primitives instead of rolling their own infprastructure to implement
> devices and drivers binding.

If you don't object to this driver going in, and there is a path forward
in the future for it to be able to be removed, then I will be glad to
add it.

Can I add your Acked-by: to the patch for this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/