linux-kernel - Re: [PATCH v2] regulator: regulator disable supply fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1288778885.3277.14.camel@odin>
Date:	Wed, 03 Nov 2010 10:08:05 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Mattias Wallin <mattias.wallin@...ricsson.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] regulator: regulator disable supply fix

On Tue, 2010-11-02 at 14:55 +0100, Mattias Wallin wrote:
> This patch fixes a disable failure when regulator supply is used.
> A while loop in regulator disable checks for supply pointer != NULL
> but the pointer is not always updated, resulting in the while loop
> running too many times causing a disable failure.
> 
> Signed-off-by: Mattias Wallin <mattias.wallin@...ricsson.com>
> Acked-by: Linus Walleij <linus.walleij@...ricsson.com>
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> ---
>  drivers/regulator/core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index f1d10c9..c625633 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1359,6 +1359,7 @@ static int _regulator_disable(struct regulator_dev *rdev,
>  		struct regulator_dev **supply_rdev_ptr)
>  {
>  	int ret = 0;
> +	*supply_rdev_ptr = NULL;
>  
>  	if (WARN(rdev->use_count <= 0,
>  			"unbalanced disables for %s\n",

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/