linux-kernel - Re: [PATCH 1/6] hid: egalax: Use kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1011041041010.15851@pobox.suse.cz>
Date:	Thu, 4 Nov 2010 10:41:10 -0400 (EDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Chase Douglas <chase.douglas@...onical.com>
Cc:	Henrik Rydberg <rydberg@...omail.se>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Philipp Merkel <mail@...lmerk.de>,
	Stephane Chatty <chatty@...c.fr>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] hid: egalax: Use kzalloc

On Wed, 13 Oct 2010, Chase Douglas wrote:

> > To avoid unnecessary explicit initialization, allocate zeroed memory.
> > 
> > Signed-off-by: Henrik Rydberg <rydberg@...omail.se>
> > ---
> >  drivers/hid/hid-egalax.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/hid/hid-egalax.c b/drivers/hid/hid-egalax.c
> > index 54b017a..5a1b52e 100644
> > --- a/drivers/hid/hid-egalax.c
> > +++ b/drivers/hid/hid-egalax.c
> > @@ -221,7 +221,7 @@ static int egalax_probe(struct hid_device *hdev, const struct hid_device_id *id)
> >  	struct egalax_data *td;
> >  	struct hid_report *report;
> >  
> > -	td = kmalloc(sizeof(struct egalax_data), GFP_KERNEL);
> > +	td = kzalloc(sizeof(struct egalax_data), GFP_KERNEL);
> >  	if (!td) {
> >  		dev_err(&hdev->dev, "cannot allocate eGalax data\n");
> >  		return -ENOMEM;
> 
> Pretty obvious.
> 
> Acked-by: Chase Douglas <chase.douglas@...onical.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/