linux-kernel - Re: REGRESSION: Re: [GIT] kconfig rc fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101104101910.920efbed.randy.dunlap@oracle.com>
Date:	Thu, 4 Nov 2010 10:19:10 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Arnaud Lacombe <lacombar@...il.com>, Michal Marek <mmarek@...e.cz>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	kyle@...hat.com, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: REGRESSION: Re: [GIT] kconfig rc fixes

On Thu, 04 Nov 2010 07:10:11 -0400 Mauro Carvalho Chehab wrote:

> All dependencies required by the selected symbols are satisfied. For example,
> the simplest case is likely cafe_ccic, as, currently, there's just one possible
> driver that can be attached dynamically at runtime to cafe_ccic. We have:
> 
> menu "Encoders/decoders and other helper chips"
> 	depends on !VIDEO_HELPER_CHIPS_AUTO
> 
> ...
> config VIDEO_OV7670
>         tristate "OmniVision OV7670 sensor support"
>         depends on I2C && VIDEO_V4L2
> ...
> endmenu
> 
> config VIDEO_CAFE_CCIC
>         tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
>         depends on PCI && I2C && VIDEO_V4L2
>         select VIDEO_OV7670
> 
> The dependencies needed by ov7670 (I2C and VIDEO_V4L2) are also dependencies of 
> cafe_ccic. So, it shouldn't have any problem for it to work (and it doesn't have,
> really. This is working as-is during the last 4 years).

This warning line:

warning: (VIDEO_CAFE_CCIC && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && PCI && I2C && VIDEO_V4L2 || VIDEO_VIA_CAMERA && MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && VIDEO_V4L2 && FB_VIA) selects VIDEO_OV7670 which has unmet direct dependencies (MEDIA_SUPPORT && VIDEO_CAPTURE_DRIVERS && !VIDEO_HELPER_CHIPS_AUTO && I2C && VIDEO_V4L2)

is not caused by CAFE_CCIC -- it's caused by VIDEO_VIA_CAMERA, because
VIDEO_HELPER_CHIPS_AUTO=y, so !VIDEO_HELPER_CHIPS_AUTO is false, so
VIDEO_OV7670 should not be available since it depends on
!VIDEO_HELPER_CHIPS_AUTO.

Below is a simple patch that reduces the kconfig warning count in 2.6.37-rc1
from 240 down to only 88.  :)


> It should be noticed that, even if we replace the menu dependencies by an
> If, won't solve. I tried the enclosed patch, to see if it would produce something
> that the new Kconfig behavior accepts. The same errors apply.

That does not change any kconfig symbol logic/truth values.

> It is fine for me if you want/need to change the way Kconfig works, provided
> that it won't break (or produce those annoying warnings) the existing logic, and
> won't open the manual select menu, if the user selects the auto mode.
> Just send us a patch changing it to some other way of doing it.
> 
> Thanks,
> Mauro
> ---

From: Randy Dunlap <randy.dunlap@...cle.com>

Clean up some video driver dependencies.
Reduces the kconfig warning for unmet dependencies from 240
down to only 88 in 2.6.37-rc1.

This makes the drivers in the VIDEO_HELPER_CHIPS_AUTO menu not
be dependent on that symbol.  Just splash a comment there
instead.  config tools will display the comment when
VIDEO_HELPER_CHIPS_AUTO is false.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 drivers/media/video/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)

--- linux-2.6.37-rc1-git3.orig/drivers/media/video/Kconfig
+++ linux-2.6.37-rc1-git3/drivers/media/video/Kconfig
@@ -112,6 +112,10 @@ config VIDEO_IR_I2C
 #
 
 menu "Encoders/decoders and other helper chips"
+
+comment "Only change these kconfig Helper/Auto settings if you are sure"
+	depends on !VIDEO_HELPER_CHIPS_AUTO
+comment "that you know what you are doing"
 	depends on !VIDEO_HELPER_CHIPS_AUTO
 
 comment "Audio decoders"
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/