linux-kernel - Re: [PATCH] pm_qos: Fix reversed min and max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101104180107.GA20826@gvim.org>
Date:	Thu, 4 Nov 2010 14:01:07 -0400
From:	mark gross <markgross@...gnar.org>
To:	Colin Cross <ccross@...roid.com>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	mark gross <markgross@...gnar.org>,
	James Bottomley <James.Bottomley@...e.de>,
	stable <stable@...nel.org>
Subject: Re: [PATCH] pm_qos: Fix reversed min and max

On Wed, Nov 03, 2010 at 11:40:03PM -0700, Colin Cross wrote:
> pm_qos_get_value had min and max reversed, causing all pm_qos
> requests to have no effect.
sorry.

Acked-by : mark <markgross@...gnar.org>
 

--mgross
 
> Change-Id: I252c764821eac8d94de57eb482c05bf6afcea15b
> Cc: "Rafael J. Wysocki" <rjw@...k.pl>
> Cc: mark gross <markgross@...gnar.org>
> Cc: James Bottomley <James.Bottomley@...e.de>
> Cc: stable <stable@...nel.org>
> Signed-off-by: Colin Cross <ccross@...roid.com>
> ---
>  kernel/pm_qos_params.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> index 645e541..0da2837 100644
> --- a/kernel/pm_qos_params.c
> +++ b/kernel/pm_qos_params.c
> @@ -120,10 +120,10 @@ static inline int pm_qos_get_value(struct pm_qos_object *o)
>  
>  	switch (o->type) {
>  	case PM_QOS_MIN:
> -		return plist_last(&o->requests)->prio;
> +		return plist_first(&o->requests)->prio;
>  
>  	case PM_QOS_MAX:
> -		return plist_first(&o->requests)->prio;
> +		return plist_last(&o->requests)->prio;
>  
>  	default:
>  		/* runtime check for not using enum */
> -- 
> 1.7.3.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/