linux-kernel - Re: [linux-pm] [GIT PULL] One more power management fix for 2.6.37

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101104062709.GA3118@isilmar-3.linta.de>
Date:	Thu, 4 Nov 2010 07:27:09 +0100
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux-pm mailing list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [linux-pm] [GIT PULL] One more power management fix for 2.6.37

On Thu, Nov 04, 2010 at 06:04:05AM +0100, Rafael J. Wysocki wrote:
> On Wednesday, November 03, 2010, Dominik Brodowski wrote:
> > > There's apparently an ordering problem with dpm_list_mtx and
> > > socket->skt_mutex. Lockdep details appended.
> > > 
> > > Dominik, Rafael? What's the proper locking order here, and
> > > how do we fix this?
> > 
> > Thanks for noting this; let's see:
> > 
> > - We add a PCMCIA device holding skt_mutex, therefore we have the ordering
> >   (1) skt_mutex -> (2) dpm_list_mtx
> > 
> > - If we're suspending, dpm_list_mtx is held, but we need to acquire
> >   skt_mutex as we modify some data being protected by skt_mutex
> >   (1) dpm_list_mtx -> (2) skt_mutex
> > 
> > Rafael, any idea on how to solve this? How do other subsystems handle such
> > an issue? Do they call device_add() with no locks held at all?
> 
> They usually do from what I can tell.
> 
> Also only a few of them implement the ->suspend_noirq() callback, which is the
> one executed under dpm_list_mtx.
> 
> What exactly is protected by skt_mutex ?

e.g.
struct pcmcia_socket {
	...
        u_int                   suspended_state;
        int                     resume_status;
	...
}

Furthermore, one has to acquire skt_mutex first before obtaining ops_mutex,
which protects many more fields (and asserts exclusion for some code paths),
see Documentation/pcmcia/locking.txt for details.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/