linux-kernel - Re: [PATCH 10/49] drivers/gpu: Use vzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CD3CE7C.4040407@shipmail.org>
Date:	Fri, 05 Nov 2010 10:29:32 +0100
From:	Thomas Hellstrom <thomas@...pmail.org>
To:	Joe Perches <joe@...ches.com>
CC:	Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 10/49] drivers/gpu: Use vzalloc

On 11/05/2010 04:07 AM, Joe Perches wrote:
> Signed-off-by: Joe Perches<joe@...ches.com>
>    
Reviewed-by: Thomas Hellstrom <thellstrom@...are.com>

> ---
>   drivers/gpu/drm/via/via_dmablit.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/via/via_dmablit.c b/drivers/gpu/drm/via/via_dmablit.c
> index 9b5b4d9..3e038a3 100644
> --- a/drivers/gpu/drm/via/via_dmablit.c
> +++ b/drivers/gpu/drm/via/via_dmablit.c
> @@ -235,9 +235,9 @@ via_lock_all_dma_pages(drm_via_sg_info_t *vsg,  drm_via_dmablit_t *xfer)
>   	vsg->num_pages = VIA_PFN(xfer->mem_addr + (xfer->num_lines * xfer->mem_stride - 1)) -
>   		first_pfn + 1;
>
> -	if (NULL == (vsg->pages = vmalloc(sizeof(struct page *) * vsg->num_pages)))
> +	vsg->pages = vzalloc(sizeof(struct page *) * vsg->num_pages);
> +	if (NULL == vsg->pages)
>   		return -ENOMEM;
> -	memset(vsg->pages, 0, sizeof(struct page *) * vsg->num_pages);
>   	down_read(&current->mm->mmap_sem);
>   	ret = get_user_pages(current, current->mm,
>   			     (unsigned long)xfer->mem_addr,
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/