[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4CD3EF31.9060909@linux.intel.com>
Date: Fri, 05 Nov 2010 07:49:05 -0400
From: Arjan van de Ven <arjan@...ux.intel.com>
To: Youquan Song <youquan.song@...ux.intel.com>
CC: davej@...hat.com, venki@...gle.com, youquan.song@...el.com,
cpufreq-list@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Fix ondemand governor powersave_bias execution
time misuse
On 11/5/2010 11:19 AM, Youquan Song wrote:
> Ondemand governor use powersave_bias tunable to do aggressive power save by
> decrease CPU average frequency. The average frequency achieve by adjust low and
> high frequency's execution time proportion during one sample time interval.
>
> Current kernel, only the high frequency executes in time proportion, but the low
> frequency wrongly execute in one whole sample time interval when powersave_bias
> is set.
>
> The patch fix it by set low frequency execution time to it deserved.
>
> Signed-off-by: Youquan Song<youquan.song@...el.com>
> ---
while your patch looks correct, I think the whole feature is wonky and
likely ought to be removed...........
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists