linux-kernel - Re: [Cbe-oss-dev] [PATCH 03/49] arch/powerpc: Use vzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201011050908.50190.jk@ozlabs.org>
Date:	Fri, 5 Nov 2010 09:08:49 -0400
From:	Jeremy Kerr <jk@...abs.org>
To:	cbe-oss-dev@...ts.ozlabs.org
Cc:	Joe Perches <joe@...ches.com>, Jiri Kosina <trivial@...nel.org>,
	kvm@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Alexander Graf <agraf@...e.de>, kvm-ppc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
	linuxppc-dev@...ts.ozlabs.org, Avi Kivity <avi@...hat.com>
Subject: Re: [Cbe-oss-dev] [PATCH 03/49] arch/powerpc: Use vzalloc

Hi Joe,

> diff --git a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
> b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c index a101abf..3b894f5
> 100644
> --- a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
> +++ b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c
> @@ -36,10 +36,9 @@ static int spu_alloc_lscsa_std(struct spu_state *csa)
>  	struct spu_lscsa *lscsa;
>  	unsigned char *p;
> 
> -	lscsa = vmalloc(sizeof(struct spu_lscsa));
> +	lscsa = vzalloc(sizeof(struct spu_lscsa));
>  	if (!lscsa)
>  		return -ENOMEM;
> -	memset(lscsa, 0, sizeof(struct spu_lscsa));
>  	csa->lscsa = lscsa;
> 
>  	/* Set LS pages reserved to allow for user-space mapping. */

For the spufs bit:

Acked-By: Jeremy Kerr <jk@...abs.org>

Cheers,


Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/