linux-kernel - Re: [PATCH] leds-net5501: taints kernel, add license

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1288964426.28481.15863.camel@rex>
Date:	Fri, 05 Nov 2010 13:40:26 +0000
From:	Richard Purdie <rpurdie@...ys.net>
To:	Randy Dunlap <randy.dunlap@...cle.com>,
	akpm <akpm@...ux-foundation.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	torvalds <torvalds@...ux-foundation.org>,
	Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH] leds-net5501: taints kernel, add license

On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Add MODULE_LICENSE() that matches file comments so that kernel
> is not tainted.
> 
> 	leds_net5501: module license 'unspecified' taints kernel.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Acked-by: Richard Purdie <rpurdie@...ux.intel.com>

> ---
>  drivers/leds/leds-net5501.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
> 
> 
> --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
> +++ lnx-2637-rc1/drivers/leds/leds-net5501.c
> @@ -92,3 +92,5 @@ unmap:
>  }
>  
>  arch_initcall(soekris_init);
> +
> +MODULE_LICENSE("GPL");
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/