linux-kernel - Re: [PATCH 1/2] perf bench: port memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=imdtoGqZZj69pZCjSdFB5vAD334skSBhVEFjd@mail.gmail.com>
Date:	Sat, 6 Nov 2010 02:10:51 +0900
From:	Hitoshi Mitake <h.mitake@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	"Ma Ling:" <ling.ma@...el.com>, Zhao Yakui <yakui.zhao@...el.com>,
	Paul Mackerras <paulus@...ba.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Hitoshi Mitake <mitake@....info.waseda.ac.jp>
Subject: Re: [PATCH 1/2] perf bench: port memcpy_64.S to perf bench

On Sat, Oct 30, 2010 at 06:08, Arnaldo Carvalho de Melo
<acme@...stprotocols.net> wrote:
> Em Fri, Oct 29, 2010 at 09:49:11PM +0200, Peter Zijlstra escreveu:
>> On Sat, 2010-10-30 at 01:01 +0900, Hitoshi Mitake wrote:
>> > +++ b/arch/x86/lib/memcpy_64.S
>> > @@ -1,10 +1,23 @@
>> >  /* Copyright 2002 Andi Kleen */
>> >
>> > +/*
>> > + * perf bench adoption by Hitoshi Mitake
>> > + * PERF_BENCH means that this file is included from
>> > + * the source files under tools/perf/ for benchmark programs.
>> > + *
>> > + * You don't have to care about PERF_BENCH when
>> > + * you are working on the kernel.
>> > + */
>> > +
>> > +#ifndef PERF_BENCH
>>
>> I don't like littering the actual kernel code with tools/perf/
>> ifdeffery..
>
> Yeah, this kind of problem appeared in the past, we can't use things
> that weren't specifically designed to be shared, the discussion about
> how to properly share things between the kernel and things in tools
> still has to happen.

OK, it seems that I have to consider better solution.
Could you tell me about the past problem for reference?
Your experience must be useful for this case.

-- 
Hitoshi Mitake
h.mitake@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/