lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 05 Nov 2010 12:19:49 -0500 From: Alex Elder <aelder@....com> To: Vasiliy Kulikov <segooon@...il.com> Cc: kernel-janitors@...r.kernel.org, xfs-masters@....sgi.com, Christoph Hellwig <hch@....de>, Dave Chinner <dchinner@...hat.com>, Eric Sandeen <sandeen@...hat.com>, Arkadiusz MiĆkiewicz <arekm@...en.pl>, xfs@....sgi.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] xfs: linux-2.6: xfs_ioctl: fix information leak to userland On Sat, 2010-10-30 at 18:26 +0400, Vasiliy Kulikov wrote: > al_hreq is copied from userland. If al_hreq.buflen is not properly aligned then > xfs_attr_list will ignore the last bytes of kbuf. These bytes are unitialized. > It leads to leaking of contents of kernel stack memory. > > Signed-off-by: Vasiliy Kulikov <segooon@...il.com> > --- > Compile tested. > > fs/xfs/linux-2.6/xfs_ioctl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/xfs/linux-2.6/xfs_ioctl.c b/fs/xfs/linux-2.6/xfs_ioctl.c > index 2ea238f..ad442d9 100644 > --- a/fs/xfs/linux-2.6/xfs_ioctl.c > +++ b/fs/xfs/linux-2.6/xfs_ioctl.c > @@ -416,7 +416,7 @@ xfs_attrlist_by_handle( > if (IS_ERR(dentry)) > return PTR_ERR(dentry); > > - kbuf = kmalloc(al_hreq.buflen, GFP_KERNEL); > + kbuf = kzalloc(al_hreq.buflen, GFP_KERNEL); > if (!kbuf) > goto out_dput; > Looks good. I will take this in and will send it to Linus for 2.6.37. Thanks. Reviewed-by: Alex Elder <aelder@....com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists