linux-kernel - Re: [PATCH v2] irq: use per_cpu kstat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1288977403.2882.928.camel@edumazet-laptop>
Date:	Fri, 05 Nov 2010 18:16:43 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, Andi Kleen <andi@...stfloor.org>,
	Tejun Heo <tj@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2] irq: use per_cpu kstat_irqs

Le vendredi 05 novembre 2010 à 11:54 -0500, Christoph Lameter a écrit :
> On Fri, 5 Nov 2010, Eric Dumazet wrote:
> 
> >  static inline void kstat_incr_irqs_this_cpu(unsigned int irq,
> >  					    struct irq_desc *desc)
> 
> desc is not used.
> 
> >  {
> > -	kstat_this_cpu.irqs[irq]++;
> > -	kstat_this_cpu.irqs_sum++;
> > +	__this_cpu_inc(kstat.irqs[irq]);
> > +	__this_cpu_inc(kstat.irqs_sum);
> >  }
> 

Thats right, but it is used in CONFIG_GENERIC_HARDIRQS case.

Prototype of this function is generic, I did not change this.

(I left the macro in CONFIG_GENERIC_HARDIRQS case too because I felt
using a function could break some arches)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/