linux-kernel - [PATCH 0/2] vfio: virtualize INTX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Nov 2010 11:30:15 -0600
From:	Alex Williamson <alex.williamson@...hat.com>
To:	pugs@...co.com
Cc:	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	kvm@...r.kernel.org, alex.williamson@...hat.com
Subject: [PATCH 0/2] vfio: virtualize INTX_DISABLE

Tom,

Since we use INTX_DISABLE internally for PCI 2.3 devices, it's probably
not a good idea to allow vfio users direct access to it.  In trying to
virtualize it, I stumbled on some config space virtualization issues.
I think we want vconfig and the value written to hardware to be different
when there are virtualized bits, but we lump them together.  I think this
is why I've never been able to rely on the memory enable bit of config
space through vfio.  With this first patch, all virtualized bits that
are writable are sticky in vconfig.  Non-writable bits come from either
the old value or the physical hardware depending on whether it's
virtualized.  This means we can get rid of a lot of duplicated setting
and reading of vconfig, and only add code for more complicated
behaviors.  This is tricky code, to please double check that I'm not
doing something stupid.  Thanks,

Alex

---

Alex Williamson (2):
      vfio: Virtualize PCI_COMMAND_INTX_DISABLE
      vfio: Fix config space virtualization

 drivers/vfio/vfio_intrs.c      |   38 ++++++++----
 drivers/vfio/vfio_main.c       |   14 ++++
 drivers/vfio/vfio_pci_config.c |  131 ++++++++++++----------------------------
 include/linux/vfio.h           |    4 +
 4 files changed, 84 insertions(+), 103 deletions(-)

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/