linux-kernel - Re: Linux 2.6.37-rc1 (libipw remove_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CD48E04.2050709@oracle.com>
Date:	Fri, 05 Nov 2010 16:06:44 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Pavel Roskin <proski@....org>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.37-rc1 (libipw remove_proc_entry warning)

On 11/05/10 15:24, Linus Torvalds wrote:
> This bug seems to be due to commit 27ae60f8f7aac ("ipw2x00: replace
> "ieee80211" with "libipw" where appropriate"), where Pavel did this:
> 
> -       libipw_proc = proc_mkdir(DRV_NAME, init_net.proc_net);
> +       libipw_proc = proc_mkdir("ieee80211", init_net.proc_net);
> 
> but then the cleanup was kept as
> 
>         remove_proc_entry(DRV_NAME, init_net.proc_net);
> 
> in both places (both in the failure case and in the unload case). The
> error string is also total crap, and says
> 
>      "Unable to create " DRV_NAME " proc directory\n");
> 
> Even though it doesn't actually create a proc directory named DRV_NAME at all.
> 
> So that patch looks like total and utter crap to me. The commit message says
> 
>   "Keep /proc/net/ieee80211 under the original name to avoid breaking user
>     interface."
> 
> but the thing is, it really didn't fix anything but that one create
> thing. It needs to fix all the other cases too.
> 
> Totally UNTESTED patch attached. It may or may not compile. And maybe
> it doesn't catch all cases, but it should catch the obvious ones.

That works for me.

Tested-by: Randy Dunlap <randy.dunlap@...cle.com>


thanks,
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/