| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1289069612.5166.4.camel@neuromancer> Date: Sat, 06 Nov 2010 19:53:32 +0100 From: Stefan Achatz <erazor_de@...rs.sourceforge.net> To: Jiri Kosina <jkosina@...e.cz> Cc: Randy Dunlap <rdunlap@...otime.net>, Bruno Prémont <bonbons@...ux-vserver.org>, Stephane Chatty <chatty@...c.fr>, Don Prince <dhprince-devel@...oo.co.uk>, Dmitry Torokhov <dtor@...l.ru>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org Subject: [PATCH 3/3] HID: roccat: declaring meaning of pack pragma usage in kone and pyra driver Using pack pragma to prevent padding bytes in binary data structures used for hardware communication. Explanation of these pragmas was requested. This patch does for kone and pyra what another patch does for koneplus. Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net> --- drivers/hid/hid-roccat-kone.h | 3 +++ drivers/hid/hid-roccat-pyra.h | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/hid/hid-roccat-kone.h b/drivers/hid/hid-roccat-kone.h index 130d656..cb0ed99 100644 --- a/drivers/hid/hid-roccat-kone.h +++ b/drivers/hid/hid-roccat-kone.h @@ -14,6 +14,9 @@ #include <linux/types.h> +/* + * Binary data structures for communication with hardware must have no padding. + */ #pragma pack(push) #pragma pack(1) diff --git a/drivers/hid/hid-roccat-pyra.h b/drivers/hid/hid-roccat-pyra.h index 22f80a8..31d7b3e 100644 --- a/drivers/hid/hid-roccat-pyra.h +++ b/drivers/hid/hid-roccat-pyra.h @@ -14,6 +14,9 @@ #include <linux/types.h> +/* + * Binary data structures for communication with hardware must have no padding. + */ #pragma pack(push) #pragma pack(1) -- 1.7.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists