linux-kernel - Re: [PATCH 6/6] ARM: ftrace: enable function graph tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin8UO9ixVep0jKK8H5roWEVRDJW4khUpT2TpPs+@mail.gmail.com>
Date:	Sat, 6 Nov 2010 19:06:28 +0000
From:	Catalin Marinas <catalin.marinas@...il.com>
To:	Rabin Vincent <rabin@....in>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Tim Bird <tim.bird@...sony.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] ARM: ftrace: enable function graph tracer

On Saturday, November 6, 2010, Rabin Vincent <rabin@....in> wrote:
> Add the options to enable the function graph tracer on ARM.  Function
> graph tracer support requires frame pointers, so exclude Thumb-2 and
> also explicitly select FRAME_POINTER in FUNCTION_GRAPH_TRACER since
> FUNCTION_TRACER doesn't select FRAME_POINTER when ARM_UNWIND is used
> Therefore, with GCC 4.4.0+, you get plain function tracing without frame
> pointers, but you'll need them if you want function graph tracing.
.....
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -141,6 +141,7 @@ config FUNCTION_TRACER
>
>  config FUNCTION_GRAPH_TRACER
>         bool "Kernel Function Graph Tracer"
> +       select FRAME_POINTER if ARM_UNWIND

Would it be better to modify FRAME_POINTER definition in the ARM
Kconfig so that it is enabled automatically when FUNCTION_GRAPH_TRACER
is enabled?

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/