linux-kernel - Re: [PATCH] [USB] UAS: Achitecture; TMF; more

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101106103650.6d4a5342@lxorguk.ukuu.org.uk>
Date:	Sat, 6 Nov 2010 10:36:50 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	ltuikov@...oo.com
Cc:	Greg KH <greg@...ah.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Matthew Wilcox <willy@...ux.intel.com>
Subject: Re: [PATCH] [USB] UAS: Achitecture; TMF; more

> I did want to submit them one at a time. I really did. But one change
> necessitated another in order to keep things consistent, and it ended
> up like this, one single commit in my git tree.

You can still dice it up into small bits.

Having done this before a few times when I've ended up in the same
situation (either by my own lack of planning or by being handed a blob by
and told my job is to sort it out) a few tips.

First start with the trivial bits - for example you can easily pull out
patches like

1. Add packed to dats structures that match the wire format
2. Correct the layout of sense iu
3. Add common initialisers
4. Clean up URB freeing

And while you are at it you can also lose changes by removing gratiutious
stuff like

-struct uas_dev_info {
+/* Lives in the SCSI host, hostdata points to it.
+ */
+struct uas_tport_info {

Now even if you hate the name or the qdepth field name you can deal with
it later once it is all nicely working. That would clean up the patch
noise a lot in itself

As you do that the rest becomes clearer and you can then recommit stuff
step by step. The patches need to tell a story which is "How we got from
A to B in small clearly logical steps without breaking anything on the
way"

The tagging mix should possibly also be discussed with the scsi list,
that may be the better place to fix it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/