linux-kernel - RE: [PATCH] regulator: twl-regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1289044485.3318.16.camel@odin>
Date:	Sat, 06 Nov 2010 11:54:45 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Lesly Arackal Manuel <leslyam@...com>
Cc:	"'Nayak, Rajendra'" <rnayak@...com>,
	'Axel Lin' <axel.lin@...il.com>,
	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'Juha Keski-Saari' <ext-juha.1.keski-saari@...ia.com>,
	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>
Subject: RE: [PATCH] regulator: twl-regulator - fix twlreg_set_mode

On Thu, 2010-11-04 at 15:08 +0530, Lesly Arackal Manuel wrote:
> Forgot to mention-
> 
> Only omap hsmmc driver is using regulator_set_mode() which will call
> twlreg_set_mode().
> 
> > -----Original Message-----
> > From: Lesly Arackal Manuel [mailto:leslyam@...com]
> > Sent: Thursday, November 04, 2010 3:01 PM
> > To: 'Nayak, Rajendra'; 'Liam Girdwood'
> > Cc: 'Axel Lin'; 'linux-kernel'; 'Juha Keski-Saari'; 'Mark Brown'
> > Subject: RE: [PATCH] regulator: twl-regulator - fix twlreg_set_mode
> > 
> > 
> > I have tested it with MMC card inserted on OMAP3630SDP board (using OMAP3
> > integration tree).
> > 
> > The changes seem to be valid.
> > 
> > The i2c_transfer() returns '1' on success and the twl_i2c_write() which
> > calls i2c_transfer returns '0' if success and err value if it fails.
> > 
> > After writing the MSB if it returns with check:
> > if (status >= 0)
> > 	return status;
> > It is not writing the LSB.
> > 
> > So it should be:
> > if (status < 0)
> > 	return status;
> > 
> > Regards,
> > Lesly AM
> > 

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/