linux-kernel - Re: [PATCH] perf, ui: Eliminate stack-smashing protection compiler complain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 8 Nov 2010 00:51:00 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] perf, ui: Eliminate stack-smashing protection compiler
	complain

On Sun, Nov 07, 2010 at 10:49:02PM +0100, Frederic Weisbecker wrote:
> On Sat, Nov 06, 2010 at 11:47:24AM +0300, Cyrill Gorcunov wrote:
> >  The gcc complains on Yes, No being allocated from stack space. Make
> > them conts to feel compiler happy.
> > 
> >  |    CC util/ui/util.o
> >  | cc1: warnings being treated as errors
> >  | util/ui/util.c: In function ‘ui__dialog_yesno’:
> >  | util/ui/util.c:108: error: not protecting function: no buffer at least 8 bytes long
> >  | make: *** [util/ui/util.o] Error 1
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> > CC: Arnaldo Carvalho de Melo <acme@...hat.com>
> > CC: Frédéric Weisbecker <fweisbec@...il.com>
> > CC: Ingo Molnar <mingo@...e.hu>
> > ---
> 
> I hope we can finally queue this one fix, the warning is there
> for a while now, and this patch looks quite sensible :)
> 

yup, thanks for review ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/