lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 7 Nov 2010 11:29:02 +0100 From: Borislav Petkov <bp@...64.org> To: Tracey Dent <tdent48227@...il.com> Cc: "mchehab@...hat.com" <mchehab@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Drivers: edac: Makfile: Cleaned up Makefile On Sat, Nov 06, 2010 at 03:05:07PM -0400, Tracey Dent wrote: > Changed Makefile to use <modules>-y instead of <modules>-objs. > > Signed-off-by: Tracey Dent <tdent48227@...il.com> While I don't object the change, I think your commit message should be fixed not to say _what_ your patch changes (we can see that) but to say _why_ you're making that change. See, I had to go search lkml just to find why all of a sudden <..>-objs is being changed. So please go and add text explaining that -objs is deprecated and so on. And make sure you've checked out Documentation/SubmittingPatches - it'll save you a lot of trouble in the future :). Thanks. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists