linux-kernel - Re: [PATCH 1/4] udf: Add missed protection for s_lvid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101107150601.GG5126@quack.suse.cz>
Date:	Sun, 7 Nov 2010 16:06:01 +0100
From:	Jan Kara <jack@...e.cz>
To:	Alessio Igor Bogani <abogani@...ware.it>
Cc:	Jan Kara <jack@...e.cz>, Arnd Bergmann <arnd@...db.de>,
	Christoph Hellwig <hch@...radead.org>,
	Tim Bird <tim.bird@...sony.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] udf: Add missed protection for s_lvid_dirty

On Sat 06-11-10 18:47:08, Alessio Igor Bogani wrote:
> As reported in udf_sb.h the udf_sb_infoi's structure member s_lvid_dirty should
> be protected by s_alloc_mutex. Added that mutex on a couple of places where it
> miss.
> 
> This work was supported by a hardware donation from the CE Linux Forum.
  Thanks for doing the work! I actually did some work on BKL removal in UDF
before I learned that you also started working on it. My series is not
complete and needs testing but the sb-locking is better explained there I
think so it should address Christoph's comments. So could you maybe base your
changes on patches I already have?
  I've pushed the branch with my BKL patches to:
git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-udf-2.6
  to branch
bkl_removal
  Basically it is missing removal of BKL usage for protection of extents
in a buffer. I wanted to use inode->i_alloc_sem for that if it won't be too
ugly, otherwise some fs-private rw semaphore. I specifically didn't want to
use mutex because that would unnecessarily serialize parallel readers.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/