linux-kernel - Re: [PATCH] Fix Winbond CIR driver initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101107154648.4bcdfb9f@lxorguk.ukuu.org.uk>
Date:	Sun, 7 Nov 2010 15:46:48 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sean Young <sean@...s.org>
Cc:	David Härdeman <david@...deman.nu>,
	linux-kernel@...r.kernel.org, jesse.barnes@...el.com
Subject: Re: [PATCH] Fix Winbond CIR driver initialisation

> A workaround is to boot with argument 8250.nr_uarts=1. This is not really 
> desirable, so this patch makes ttyS1 go away.

setserial can also be used for this surely ?

> +		dev_info(device, "Unregistering phony serial port ttyS1\n");
> +		serial8250_unregister_port(1);
> +		ok = request_region(data->sbase, SP_IOMEM_LEN, DRVNAME);

That's a hack that is only going to work on specific systems where it is
mapped the way you expect and doing stuff behind the back of the serial
driver.

I'm not averse to a better solution but it needs to be general and
maintainable. Is there a way to identify the presence of the windbond CIR
device as opposed to an 8250 ?

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/