linux-kernel - Re: [PATCH 02/16 v2] pramfs: super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimAMAmdmJBELBmnZNycBv8nOwEf+b3EUCHEiF_9@mail.gmail.com>
Date:	Mon, 8 Nov 2010 18:42:48 +0800
From:	yidong zhang <zhangyd6@...il.com>
To:	Marco Stornelli <marco.stornelli@...il.com>
Cc:	linux-kernel@...r.kernel.org, tim.bird@...sony.com,
	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 02/16 v2] pramfs: super block operations

hi Marco
> +       retval = 0;
> + out:
> +       if (retval && sbi->virt_addr) {
> +               iounmap(sbi->virt_addr);
> +               release_mem_region(sbi->phys_addr, initsize);
> +       }
> +
> +       return retval;
> +}
 Should add kfree(sbi) here in case of  failure?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/