linux-kernel - Re: [PATCH] gpu: drm: vmwgfx: fix information leak to userland

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CD81A0B.30209@vmware.com>
Date:	Mon, 08 Nov 2010 16:40:59 +0100
From:	Thomas Hellstrom <thellstrom@...are.com>
To:	Vasiliy Kulikov <segooon@...il.com>
CC:	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	Dave Airlie <airlied@...hat.com>,
	Jakob Bornecrantz <jakob@...are.com>,
	Dan Carpenter <error27@...il.com>,
	Jerome Glisse <jglisse@...hat.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpu: drm: vmwgfx: fix information leak to userland

On 11/06/2010 03:41 PM, Vasiliy Kulikov wrote:
> Structure drm_vmw_fence_rep is copied to userland with field "pad64"
> uninitialized.  It leads to leaking of contents of kernel stack memory.
>
> Signed-off-by: Vasiliy Kulikov<segooon@...il.com>
> ---
>   Compile tested.
>
>   drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 51d9f9f..76954e3 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -691,6 +691,7 @@ int vmw_execbuf_ioctl(struct drm_device *dev, void *data,
>
>   	fence_rep.error = ret;
>   	fence_rep.fence_seq = (uint64_t) sequence;
> +	fence_rep.pad64 = 0;
>
>   	user_fence_rep = (struct drm_vmw_fence_rep __user *)
>   	    (unsigned long)arg->fence_rep;
>    
Reviewed-by: Thomas Hellstrom <thellstrom@...are.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/