linux-kernel - RE: [PATCH] Cypress WestBridge OMAP3430 Kernel Hal: Remove unneeded local variables from alloc functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8E4F99B145E24F26B937AE2EE1316F09@stanford.edu>
Date:	Mon, 8 Nov 2010 10:54:25 -0800
From:	"David Cross" <david.cross@...ress.com>
To:	"'Jesper Juhl'" <jj@...osbits.net>, <linux-kernel@...r.kernel.org>
Cc:	"'Greg Kroah-Hartman'" <gregkh@...e.de>
Subject: RE: [PATCH] Cypress WestBridge OMAP3430 Kernel Hal: Remove unneeded local variables from alloc functions


> In 
> drivers/staging/westbridge/astoria/arch/arm/mach->
omap2/cyashalomap_kernel.c
> the local variables 'ret_p' are not needed and should just go away.

> I have no way to test this code, but I believe the change is obviously 
> correct. Please consider it.

I agree. ACK. thanks for the review.

> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  cyashalomap_kernel.c |   10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

> diff --git
a/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.
c
b/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.
c
> index a678029..ad0c61d 100644
> ---
a/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.
c
> +++
b/drivers/staging/westbridge/astoria/arch/arm/mach-omap2/cyashalomap_kernel.
c
> @@ -2127,10 +2127,7 @@ void
cy_as_hal_pll_lock_loss_handler(cy_as_hal_device_tag tag)
>   */
>  void *cy_as_hal_alloc(uint32_t cnt)
>  {
> -	void *ret_p;
> -
> -	ret_p = kmalloc(cnt, GFP_ATOMIC);
> -	return ret_p;
> +	return kmalloc(cnt, GFP_ATOMIC);
>  }
>
>  /*
> @@ -2150,10 +2147,7 @@ void cy_as_hal_free(void *mem_p)
>   */
>  void *cy_as_hal_c_b_alloc(uint32_t cnt)
>  {
> -	void *ret_p;
> -
> -	ret_p = kmalloc(cnt, GFP_ATOMIC);
> -	return ret_p;
> +	return kmalloc(cnt, GFP_ATOMIC);
>  }
>  
>  /*
>
>
> -- 
> Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
> Plain text mails only, please      http://www.expita.com/nomime.html
> Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html

david

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/