linux-kernel - Re: [PATCH] x86: fix apic.h unused but set warnings v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oc9zqy0l.fsf@basil.nowhere.org>
Date:	Mon, 08 Nov 2010 22:57:30 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>, x86@...nel.org
Subject: Re: [PATCH] x86: fix apic.h unused but set warnings v2

Thomas Gleixner <tglx@...utronix.de> writes:

> On Mon, 8 Nov 2010, Andi Kleen wrote:
>>  static inline u32 native_apic_msr_read(u32 reg)
>>  {
>> -	u32 low, high;
>> +	u32 low;
>>  
>>  	if (reg == APIC_DFR)
>>  		return -1;
>>  
>> -	rdmsr(APIC_BASE_MSR + (reg >> 4), low, high);
>> -	return low;
>> +	rdmsrl(APIC_BASE_MSR + (reg >> 4), low);
>> +	return (u32)low;
>
> What's the point of casting u32 to u32 ?

One of the earlier reviewers thought adding an explicit cast would make
the truncation in the code clearer.  I didn't full agree either, but 
still did the change.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/