linux-kernel - Re: [Security] [PATCH] Restrict unprivileged access to kernel syslog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikee8A3Un9VoXnGO2n51Vs1Qv=whAbjM5VM=Mrq@mail.gmail.com>
Date:	Tue, 9 Nov 2010 13:39:18 +0800
From:	Eugene Teo <eugeneteo@...nel.sg>
To:	Kees Cook <kees.cook@...onical.com>
Cc:	Dan Rosenberg <drosenberg@...curity.com>, security@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Security] [PATCH] Restrict unprivileged access to kernel syslog

On Tue, Nov 9, 2010 at 1:34 PM, Kees Cook <kees.cook@...onical.com> wrote:
> On Mon, Nov 08, 2010 at 10:28:58PM -0500, Dan Rosenberg wrote:
>> The kernel syslog contains debugging information that is often useful
>> during exploitation of other vulnerabilities, such as kernel heap
>> addresses.  Rather than futilely attempt to sanitize hundreds (or
>> thousands) of printk statements and simultaneously cripple useful
>> debugging functionality, it is far simpler to create an option that
>> prevents unprivileged users from reading the syslog.
>>
>> This patch, loosely based on grsecurity's GRKERNSEC_DMESG, creates the
>> dmesg_restrict sysctl.  When set to "0", the default, no restrictions
>> are enforced.  When set to "1", only users with CAP_SYS_ADMIN can read
>> the kernel syslog via dmesg(8) or other mechanisms.
>>
>> Signed-off-by: Dan Rosenberg <drosenberg@...curity.com>
>
> Acked-by: Kees Cook <kees.cook@...onical.com>
>
> This looks good to me -- it leaves the /proc file access alone for
> priv-dropping ksyslogd implementations.

Acked-by: Eugene Teo <eugeneteo@...nel.org>

Looks good to me too. Thanks.

Eugene
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/