linux-kernel - Re: [v2][PATCH] [v2] Revalidate page->mapping in do_generic_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20101108160555.2925ea57.akpm@linux-foundation.org>
Date:	Mon, 8 Nov 2010 16:05:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	arunabal@...ibm.com, sbest@...ibm.com, stable <stable@...nel.org>,
	Christoph Hellwig <hch@....de>,
	Al Viro <viro@...iv.linux.org.uk>,
	Rik van Riel <riel@...hat.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Johannes Weiner <hannes@...xchg.org>
Subject: Re: [v2][PATCH] [v2] Revalidate page->mapping in
 do_generic_file_read()

On Fri, 05 Nov 2010 14:16:15 -0700
Dave Hansen <dave@...ux.vnet.ibm.com> wrote:

> --- linux-2.6.git/mm/filemap.c~is_partially_uptodate-revalidate-page	2010-11-03 13:49:21.000000000 -0700
> +++ linux-2.6.git-dave/mm/filemap.c	2010-11-04 06:59:08.000000000 -0700
> @@ -1016,6 +1016,9 @@ find_page:
>  				goto page_not_up_to_date;
>  			if (!trylock_page(page))
>  				goto page_not_up_to_date;
> +			/* Did it get truncated before we got the lock? */
> +			if (!page->mapping)
> +				goto page_not_up_to_date_locked;
>  			if (!mapping->a_ops->is_partially_uptodate(page,
>  								desc, offset))
>  				goto page_not_up_to_date_locked;

whoops.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/