linux-kernel - Re: [PATCH] input: touchscreen: s3c2410: Add ABS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Nov 2010 07:54:55 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Marek Belisko <marek.belisko@...il.com>
Cc:	Vincent Sanders <support@...tec.co.uk>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: touchscreen: s3c2410: Add ABS_PRESSURE event
 sending.

On Tue, Nov 09, 2010 at 02:00:16PM +0100, Marek Belisko wrote:
> This patch add sending of event ABS_PRESSURE for
> s3c24xx touchscreen.
> 
> Signed-off-by: Marek Belisko <marek.belisko@...il.com>
> ---
>  drivers/input/touchscreen/s3c2410_ts.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/s3c2410_ts.c b/drivers/input/touchscreen/s3c2410_ts.c
> index 8feb7f3..a937105 100644
> --- a/drivers/input/touchscreen/s3c2410_ts.c
> +++ b/drivers/input/touchscreen/s3c2410_ts.c
> @@ -126,6 +126,7 @@ static void touch_timer_fire(unsigned long data)
>  			input_report_abs(ts.input, ABS_Y, ts.yp);
>  
>  			input_report_key(ts.input, BTN_TOUCH, 1);
> +			input_report_abs(ts.input, ABS_PRESSURE, 1);

No, if device does not provide true pressure readings it should not send
ABS_PRESSURE events. Please fix your userspace.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/