[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20101109084206.1b6ac66a@jbarnes-desktop>
Date: Tue, 9 Nov 2010 08:42:06 -0800
From: Jesse Barnes <jbarnes@...tuousgeek.org>
To: Martin Wilck <martin.wilck@...fujitsu.com>
Cc: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Wichert, Gerhard" <gerhard.wichert@...fujitsu.com>,
Greg KH <greg@...ah.com>
Subject: Re: [PATCH] fix size checks for mmap() on /proc/bus/pci files
(resent)
On Tue, 09 Nov 2010 10:43:07 +0100
Martin Wilck <martin.wilck@...fujitsu.com> wrote:
> Hi Jesse & linux-pci,
>
> may I kindly ask if anyone has had a look at this patch yet?
>
> https://patchwork.kernel.org/patch/270271/
> http://kerneltrap.org/mailarchive/linux-kernel/2010/10/21/4635039
Yes I looked at it, and then promptly lost it in my inbox.
Thanks for fixing this; /proc/bus/pci semantics are definitely
different than /sys so we definitely want this.
I don't really like the new int argument to pci_mmap_fits (it's not
obvious from reading callers what that arg would do), maybe you could
make it into an enum that better describes the API or semantic being
used for the check?
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists