linux-kernel - Re: [PATCH v2] hwmon: (gpio-fan) Fix fan_ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Nov 2010 10:20:56 -0800
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Simon Guinot <sguinot@...ie.com>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>
Subject: Re: [PATCH v2] hwmon: (gpio-fan) Fix fan_ctrl_init error path

On Tue, 2010-11-09 at 03:41 -0500, Axel Lin wrote:
> In current implementation, the sysfs entries is not removed before return -ENODEV.
> 
> Creating the sysfs attribute should be the last thing done by the function,
> after all the rest has been successful.
> Otherwise there is a small window during which user-space can access the attribute
> but the driver isn't ready to deal with the requests.
> 
> Fix it by moving sysfs_create_group to be the last thing done by the function.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied.

Thanks,
Guenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/