linux-kernel - Re: [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTime8YvyHysZF5sX6V2mXWJ0FUtdecpVFgRGqYm6@mail.gmail.com>
Date:	Tue, 9 Nov 2010 10:23:25 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include/linux/kernel.h: Move logging bits to include/linux/logging.h

On Mon, Nov 8, 2010 at 9:38 PM, Joe Perches <joe@...ches.com> wrote:
> Move the logging bits from kernel.h into logging.h so that
> there is a bit more logical separation of the generic from
> the logging specific parts.
>
> Add pr_<level>_once macros to logging.h.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  include/linux/kernel.h  |  246 +-----------------------------------
>  include/linux/logging.h |  322 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 324 insertions(+), 244 deletions(-)
>  create mode 100644 include/linux/logging.h

I detest patches like this.

The code movement makes it really hard to see what changed. So if you
do code movement, please do _only_ code movement, and send a separate
patch that actually changes things.

                             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/