linux-kernel - Re: [PATCH] hwmon: (ad7414) Return proper error code for ad7414

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101108214142.6e2556ac@lappy.seanm.ca>
Date:	Mon, 8 Nov 2010 21:41:42 -0500
From:	Sean MacLennan <smaclennan@...atech.com>
To:	"Axel Lin" <axel.lin@...il.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Jean Delvare" <khali@...ux-fr.org>, <lm-sensors@...sensors.org>
Subject: Re: [PATCH] hwmon: (ad7414) Return proper error code for
 ad7414_probe()

On Mon, 8 Nov 2010 20:40:34 -0500
"Axel Lin" <axel.lin@...il.com> wrote:

> [PATCH] hwmon: (ad7414) Return proper error code for ad7414_probe()
> 
> Return proper error if i2c_check_functionality reports
> the adapter does not support the capability we need.
> 
> Also remove unneeded initialization for err variable.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by: Sean MacLennan <smaclennan@...atech.com>

> ---
>  drivers/hwmon/ad7414.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
> index 1e4c21f..86d822a 100644
> --- a/drivers/hwmon/ad7414.c
> +++ b/drivers/hwmon/ad7414.c
> @@ -178,11 +178,13 @@ static int ad7414_probe(struct i2c_client
> *client, {
>         struct ad7414_data *data;
>         int conf;
> -       int err = 0;
> +       int err;

I wouldn't mind if this was "int conf, err;", but I don't mind the way
it is.

Cheers,
   Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/