lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Nov 2010 11:17:56 -0800 From: Joe Perches <joe@...ches.com> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH V2] include/linux/kernel.h: Move logging bits to include/linux/logging.h On Tue, 2010-11-09 at 10:49 -0800, Linus Torvalds wrote: > On Tue, Nov 9, 2010 at 10:43 AM, Joe Perches <joe@...ches.com> wrote: > > diff from V1 - Don't add pr_<level>_once macros > > include/linux/kernel.h | 244 +-------------------------------------- > > include/linux/logging.h | 295 +++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 296 insertions(+), 243 deletions(-) > > create mode 100644 include/linux/logging.h > So where do the extra 53 lines come from now? Differences in logging.h to original kernel.h were done for cleanliness and checkpatch. o comment added for purpose of struct va_format o function no_print() broken into multiple lines o #ifdef CONFIG_PRINTK vprintk/printk block and #else block moved together o printk_ratelimit and related now have another CONFIG_PRINTK and #else block o pr_debug and pr_debug_ratelimit statement expressions are broken into multiple lines > This still is clearly not just code movement, and it's impossible for > me to see what actually changed. Something must have. If you want a nearly identical line count for logging.h, followed by a cleanup only pass of logging.h, I'll do that. Is that what you want? I didn't recompile and verify this second patch as all I did was remove the unused for now pr_<level>_once macros I added. It takes my slowish setup quite a while to do full compiles for allyesconfig/allmodconfig/ allnoconfig/defconfig/CONFIG_EMBEDDED/CONFIG_PRINTK=n variants though so it'd be another day or so before it'd be verified. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists