linux-kernel - Re: [PATCH] x86: fix apic.h unused but set warnings v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101109202215.GB4900@lenovo>
Date:	Tue, 9 Nov 2010 23:22:15 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	x86@...nel.org
Subject: Re: [PATCH] x86: fix apic.h unused but set warnings v2

On Tue, Nov 09, 2010 at 02:50:51AM +0100, Andi Kleen wrote:
> > Well, Andi I proposed to define variable as u64 and convert it back to u32 at procedure
> > exit point. That would be clean, and I still think so ;) Though I'm fine with
> > either way (I just thought about ones who will be reading this code in future,
> > and since most the rdmsrl callers already use u64 and unsigned long, this would
> > be consistent as well).
> 
> I didn't use u64 because that would use more code on i386
> 
> -Andi

Fair enough. Thanks Andi.

  Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/