| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTi=hbObSQC2=mwtb6cy399Srt-mL47zgfvth57fQ@mail.gmail.com> Date: Tue, 9 Nov 2010 21:49:54 +0000 From: Daniel J Blueman <daniel.blueman@...il.com> To: Jens Axboe <jaxboe@...ionio.com> Cc: "paulmck@...ux.vnet.ibm.com" <paulmck@...ux.vnet.ibm.com>, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [2.6.37-rc1] sys_ioprio_set and RCU locking... On 9 November 2010 20:35, Jens Axboe <jaxboe@...ionio.com> wrote: > On 2010-11-08 14:55, Jens Axboe wrote: >>>>>> Take the RCU lock for read across acquiring the pointer to the task >>>>>> credentials and dereferencing it. >>>>> >>>>> Jens, does this look sane? >>>> >>>> Yes, looks clean enough to me. >>> >>> Very good! Are you willing to take the patch in your tree? >> >> Certainly, I'm in the middle of patch monkeying now anyway. Will queue >> it up. > > The patch was buggy, I discovered that it does not do the proper > RCU unlock if we fail the uid match. Merged version here: > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=1a882abdbf9579ad0e5655f928e4ede30db301e6 Brown paper bag moment! Good catch, Jens. Dan -- Daniel J Blueman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists