linux-kernel - Re: [PATCH 2/2 v2] Unify rest of FAT messages.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Nov 2010 22:53:09 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Alexey Fisher <bug-track@...her-privat.net>
Cc:	linux-kernel@...r.kernel.org, joe@...ches.com
Subject: Re: [PATCH 2/2 v2] Unify rest of FAT messages.

Alexey Fisher <bug-track@...her-privat.net> writes:

> Am Mittwoch, den 10.11.2010, 20:40 +0900 schrieb OGAWA Hirofumi:
>> Alexey Fisher <bug-track@...her-privat.net> writes:
>> 
>> > Here is how it looks like after patch.
>> 
>> This is going to unify the all FSes (e.g. fat_msg() uses fs_msg("FAT", ...))?
>> If so, I think it's welcome. If not, umm, it looks like good but...
>
> Yea, i thought about it. It will be better to have some kernel wide
> fs_msg(). But before doing this i think one more step should be done -
> some notification interface for userspace. 
> If we get some fs errors userspace app should be notified so user too.
>
> I work currently on one case, user lost all data on FAT drive. First
> error messages was logged for some weeks, and only now some big data
> lost. There war no errors from GUI.

It clealy can happen on all FSes, not only FAT. And I don't want to push
it (notification stuff) from FAT tree. (need the review from other guys).

IMHO, it should be kernel wide (or subsystem wide) notification system
even if you target is FAT-fs only.  (yeah, it's hard to push to
linus-tree than one FS though).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/