[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1289397360.12418.119.camel@gandalf.stny.rr.com>
Date: Wed, 10 Nov 2010 08:56:00 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Rusty Russell <rusty@...tcorp.com.au>
Cc: Chris Wilson <chris@...is-wilson.co.uk>,
Yuanhan Liu <yuanhan.liu@...ux.intel.com>,
linux-kernel@...r.kernel.org, fweisbec@...il.com, mingo@...hat.com
Subject: Re: [PATCH] Delegate unknown module parameters to interested
parties
On Wed, 2010-11-10 at 16:21 +1030, Rusty Russell wrote:
> On Wed, 10 Nov 2010 01:09:21 am Steven Rostedt wrote:
> > [ Added Rusty "Module God" Russell ]
>
> And I also wrote the parameter parsing code, so sending to me is probably
> a good idea.
>
> So, what's this for? You want trace= as a standard module parameter
Yep, this way we could even enable tracepoints that are in the init
section.
> or something? If this is a once-off I'd prefer a custom hack I think.
> If you can think of other users, this might be a good idea; though don't
> use "void *data" use an explicit struct module *...
If I wrote the code, it would have been a once-off custom hack. But,
personally, I like the generic addition. Perhaps others will hook into
it without fear of having to hack the module code, which can be quite
intimidating to some.
I also agree to not use the void *data.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists