linux-kernel - Re: [PATCH v2] misc: adds support the FSA9480 USB Switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101110143110.GA5043@sirena.org.uk>
Date:	Wed, 10 Nov 2010 14:31:10 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Minkyu Kang <promsoft@...il.com>
Cc:	Greg KH <greg@...ah.com>, Minkyu Kang <mk7.kang@...sung.com>,
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	kyungmin.park@...sung.com, Ben Dooks <ben-i2c@...ff.org>
Subject: Re: [PATCH v2] misc: adds support the FSA9480 USB Switch

On Wed, Nov 10, 2010 at 09:55:34AM +0900, Minkyu Kang wrote:
> Dear Greg KH,

> > And why are you exporting symbols from this driver, that should not be
> > needed at all.

> It's for other drivers.
> For example.. When USB cable is connected, PMIC driver enable the
> power for each device. (USB, uart, audio and so on..)
> But if use the manual switch, PMIC driver can't know what device is enabled.
> So, this function was exported.

This seems like it would require the PMIC driver to have knowledge of
the USB switch driver which would be likely to give a system which is
rather board specific.  For PMIC supply management integration the
regulator API would be more normal.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/