linux-kernel - Re: [PATCH 1/4] Staging: comedi: fix brace coding style issue in ni_tio.c This is a patch to the ni_tio.c file that fixes up a brace, indentation and overlines warning found by the checkpatch.pl tool Signed-off-by: Varayud Damian Alfredo <davarayud@...il.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CDAB8ED.7070609@gmail.com>
Date:	Wed, 10 Nov 2010 16:23:25 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Damian Varayud <davarayud@...il.com>
CC:	gregkh@...e.de, harmonco@...r.orst.edu, sam.j.richardson@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] Staging: comedi: fix brace coding style issue in
 ni_tio.c This is a patch to the ni_tio.c file that fixes up a brace, indentation
 and overlines warning found by the checkpatch.pl tool Signed-off-by: Varayud
 Damian Alfredo <davarayud@...il.com>

On 11/10/2010 02:20 PM, Damian Varayud wrote:
> @@ -291,21 +296,22 @@ static void __exit ni_tio_cleanup_module(void)
> 
>  module_exit(ni_tio_cleanup_module);
> 
>  struct ni_gpct_device *ni_gpct_device_construct(struct comedi_device *dev,
> -						void (*write_register) (struct
> -									ni_gpct
> -									*
> -									counter,
> -									unsigned
> -									bits,
> -									enum
> -									ni_gpct_register
> -									reg),
> -						unsigned (*read_register)
> -						(struct ni_gpct *counter,
> -						 enum ni_gpct_register reg),
> -						enum ni_gpct_variant variant,
> -						unsigned num_counters)
> +						void (*write_register)
> +						(struct ni_gpct *counter,
> +						 unsigned bits,
> +						 enum ni_gpct_register reg),
> +						unsigned (*read_register)
> +						(struct ni_gpct *counter,
> +						 enum ni_gpct_register reg),
> +						 enum ni_gpct_variant variant,
> +						 unsigned num_counters)

I don't think this looks anyhow saner. What about shifting it left like:
               void (*write_register)(struct ni_gpct *counter,
                        unsigned bits, enum ni_gpct_register reg),
               unsigned (*read_register)(struct ni_gpct *counter,
			enum ni_gpct_register reg),
	       enum ni_gpct_variant variant, unsigned num_counters)

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/