linux-kernel - Re: [RFC][PATCH] perf: sysfs type id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101110173138.GE12371@suse.de>
Date:	Wed, 10 Nov 2010 09:31:38 -0800
From:	Greg KH <gregkh@...e.de>
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Lin Ming <ming.m.lin@...el.com>,
	Stephane Eranian <eranian@...gle.com>,
	"robert.richter" <robert.richter@....com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	fweisbec <fweisbec@...il.com>, paulus <paulus@...ba.org>,
	Kay Sievers <kay.sievers@...y.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [RFC][PATCH] perf: sysfs type id

On Wed, Nov 10, 2010 at 10:36:51AM +1100, Michael Ellerman wrote:
> On Tue, 2010-11-09 at 14:13 -0800, Greg KH wrote:
> > On Tue, Nov 09, 2010 at 10:45:19PM +0100, Peter Zijlstra wrote:
> > > The below is a RFC patch adding dynamic type ids to perf.
> > > 
> > > We need to represent PMUs in sysfs because we want to allow multiple
> > > (loadable) PMUs and need a way to identify them.
> > > 
> > > This patch creates a new device class "pmu" and adds a single attribute
> > > "type" to it. This device attribute will expose the dynamic type id as
> > > required by perf_event_attr::type.
> > > 
> > > The sysfs layout looks like:
> > > 
> > > [root@...tmere ~]# cd /sys/class/pmu/
> > 
> > You missed the embedded track at Plumbers where we talked about never
> > adding another class to the kernel.  Please use bus_id instead for this.
> 
> At least in the examples I've seen creating a bus requires a lot more
> code than a class. Or is there a shortcut I don't know about when it's a
> virtual bus?
> 
> (Interested because I have code that is using a class)

It shouldn't be that much more code to do so.  Have a pointer to some
code that you want converted over so I can show you exactly what is
needed?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/