linux-kernel - Re: [GPIO]implement sleeping GPIO chip removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1011102203500.2900@localhost6.localdomain6>
Date:	Wed, 10 Nov 2010 22:07:05 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Maciej Szmigiero <mhej@...pl>
cc:	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Uwe Kleine-K?nig <u.kleine-koenig@...gutronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Jonathan Cameron <jic23@....ac.uk>,
	Ben Nizette <bn@...sdigital.com>
Subject: Re: [GPIO]implement sleeping GPIO chip removal

Can you please use a mail client which does proper line breaks at 78 ?

On Wed, 10 Nov 2010, Maciej Szmigiero wrote:
> You misunderstood me.

No, I didnt.

> By "looping in hope that somebody will finally release the chip" I
> meant the only real way to handle a GPIO chip unplugging in the
> current kernel.  Which is way worse that preventing new requests,
> then waiting for existing one to be released.  And this is exactly
> what my patch does.

That still does not make it a good solution.

> I understand that it could be simplified by removing redundant code
> (as Grant Likely had suggested before), and moving it to completion
> interface instead of manipulating a task structure directly, but
> this doesn't mean that the whole GPIO code has to be rewritten just
> to add one functionality.

It's not about rewriting, it's about fixing the problem in the right
way and not just hacking around it.

If we see a shortcoming like this, we fix it and do not magically work
around it.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/