linux-kernel - Re: [PATCH] ipc: explicitly clear stack memory in user structs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101110020018.GH5876@outflux.net>
Date:	Tue, 9 Nov 2010 18:00:18 -0800
From:	Kees Cook <kees.cook@...onical.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	"David S. Miller" <davem@...emloft.net>,
	Hugh Dickins <hughd@...gle.com>,
	Manfred Spraul <manfred@...orfullife.com>
Subject: Re: [PATCH] ipc: explicitly clear stack memory in user structs

On Tue, Nov 09, 2010 at 05:03:30PM -0800, Joe Perches wrote:
> On Tue, 2010-11-09 at 16:54 -0800, Linus Torvalds wrote:
> > On Tue, Nov 9, 2010 at 3:48 PM, Kees Cook <kees.cook@...onical.com> wrote:
> > >> I don't quite see where you got the particular collection of people from.
> > > I used scripts/get_maintainer.pl
> > Hmm. I get totally different results. You had
> >   linux-kernel@...r.kernel.org
> >   Al Viro <viro@...iv.linux.org.uk>,
> >   Andrew Morton <akpm@...ux-foundation.org>,
> >   Jiri Slaby <jslaby@...e.cz>,
> >   "David S. Miller" <davem@...emloft.net>
> > and I get
> >   Al Viro <viro@...IV.linux.org.uk>
> >   Andrew Morton <akpm@...ux-foundation.org>
> >   Helge Deller <deller@....de>
> >   David Howells <dhowells@...hat.com>
> >   Hugh Dickins <hughd@...gle.com>
> >   linux-kernel@...r.kernel.org
> > so there is something odd going on there.
> 
> I'd like to know as well.

Well, let's see what happens. If I rewind the tree to roughly
542181d3769d001c59cd17573dd4381e87d215f2 taking a wild guess at where my
tree was when I send the patch, and run it, here's what I get:

$ ./scripts/get_maintainer.pl 0001-ipc-initialize-structure-memory-to-zero-in-shm.patch
Al Viro <viro@...iv.linux.org.uk>
Andrew Morton <akpm@...ux-foundation.org>
Jiri Slaby <jslaby@...e.cz>
"Serge E. Hallyn" <serue@...ibm.com>
"David S. Miller" <davem@...emloft.net>
linux-kernel@...r.kernel.org

And since I know Serge's address isn't at ibm any more, I dropped it from
Cc, assuming he didn't care about ipc structure fixups.

If I fast-forward to today and run it, I get the same output you do.

-Kees

-- 
Kees Cook
Ubuntu Security Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/