linux-kernel - Re: [PATCH] cifs: fix another memleak, in cifs_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1011102257400.11302@swampdragon.chaosbits.net>
Date:	Wed, 10 Nov 2010 22:59:28 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Oskar Schirmer <oskar@...ra.com>
cc:	Steve French <sfrench@...ba.org>, stable@...nel.org,
	linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Suresh Jayaraman <sjayaraman@...e.de>,
	Andrew Hendry <andrew.hendry@...il.com>
Subject: Re: [PATCH] cifs: fix another memleak, in cifs_root_iget

On Wed, 10 Nov 2010, Oskar Schirmer wrote:

> cifs_root_iget allocates full_path through
> cifs_build_path_to_root, but fails to kfree it upon
> cifs_get_inode_info* failure.
> 
> Make all failure exit paths traverse clean up
> handling at the end of the function.
> 
> Signed-off-by: Oskar Schirmer <oskar@...ra.com>
> Cc: stable@...nel.org

I've reviewed your patch (although not actually tested it) and your 
changes look sane.
So, feel free to add

Reviewed-by: Jesper Juhl <jj@...osbits.net>


-- 
Jesper Juhl <jj@...osbits.net>             http://www.chaosbits.net/
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/